- Issue created by @cestmoi
- Status changed to Needs review
over 1 year ago 2:26am 2 August 2023 @ Maintainer(s), this is my first such patch so kindly correct me where applicable.
- Status changed to Closed: duplicate
over 1 year ago 5:29am 2 August 2023 - š®š³India keshavv India
Thank you @cestmoi for your efforts.
But there is already an issue for it https://www.drupal.org/project/hashtags/issues/3127386 š Drupal 9 compatibility RTBC - Status changed to Needs review
over 1 year ago 6:39am 2 August 2023 @keshav.k thank you but that issue is for D9 not D10 and while D9 is near its EOL shouldn't efforts be on a stable D10 version ? This issue is mainly for D10 compatibility while that issue has no mention of D10. I also added fixes for issues that weren't tackled in that other issue. Anyways, I just hope this module gets the attention it needs esp. that its latest release is only D8 compatible.
With regards to the module install/enable via Drush vs UI, I think since the module cannot be required with Composer due to absence of a compatible release and it has to be added manually, installing it via Drush would cause errors such as the one below because Drush uses the Composer autoloader to load classes, and if the module is not listed in the composer.json file, its classes won't be found. That's why it installs fine via admin UI but not via Drush.
Drupal\Component\Plugin\Exception\PluginException: Plugin (filter_hashtags) instance class "Drupal\hashtags\Plugin\Filter\FilterHashtags" does not exist. in Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass() (line 97 of pathToDrupal-10\web\core\lib\Drupal\Component\Plugin\Factory\DefaultFactory.php).
That's why until there is a compatible release that can be required with Composer, the only way to enable the module is via admin UI, I understand.
I tried to `Composer require` it with the patch following this (D8/D9) tutorial but it didn't work.
- Issue was unassigned.
I think this patch is ready for RTBC. Please test and report so we have a D10 release sooner.
- Assigned to cleavinjosh
- Issue was unassigned.
- Status changed to RTBC
2 months ago 12:28pm 12 September 2024 - šµšPhilippines cleavinjosh
Hi @cestmoi,
Thank you for providing a patch.
My Drupal Version is 10.3.2
At first when I cloned the module. The website encountered an error.
I then applied patch #3, it was applied smoothly and fixed the error.
ā hashtags git:(8.x-1.0) curl https://www.drupal.org/files/issues/2023-08-03/hashtags-d10-compatibility-3378603.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 26584 100 26584 0 0 58758 0 --:--:-- --:--:-- --:--:-- 58684 patching file hashtags.info.yml patching file hashtags.install patching file hashtags.module patching file src/Form/ManagerForm.php patching file src/Form/SettingsForm.php patching file src/Plugin/Filter/FilterHashtags.php ā hashtags git:(8.x-1.0) ā
Afterwards, I installed the module successfully.
I then go to the help page and followed the instructions on how to use the module.
I go to the hashtag configuration page and enabled the hashtag in the Article content type.
I then create an article page with two lines in the body, one with hashtag and one without.
I then save the page and the line with the "#" is displayed as a link.
Clicking the link will redirect to the taxonomy term's page.
Please let me know if I missed something or did something wrong during testing.
For now, I am changing the status to RTBC since the module is working without any errors.
Thank you.