- Issue created by @sralton
- last update
over 1 year ago 2 pass - πΊπΈUnited States TolstoyDotCom L.A.
Would there be problems with using
AccountInterface
instead?See https://www.drupal.org/project/drupal/issues/3372939#comment-15172031 π Use AccountProxyInterface instead of AccountInterface Needs work
- Status changed to Needs work
about 2 months ago 2:39pm 15 February 2025 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Please use an issue fork and merge request.
- πΊπΈUnited States TolstoyDotCom L.A.
Whatever the status of https://www.drupal.org/project/drupal/issues/3372939 π Use AccountProxyInterface instead of AccountInterface Needs work , the only method this module calls on AccountProxy is hasPermission and that's in AccountInterface. So, in the issue fork I changed AccountProxy to AccountInterface. There appears to be crosstalk with the other issue fork I created so I can do this again if needed.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
As I understand it, there are two things in play here:
- Using an interface instead of a class.
- Choosing between
AccountProxyInterface
andAccountInterface
Is that right? I totally agree with using an interface.
::hasPermission()
is in both becauseAccountProxyInterface
extendsAccountInterface
, so it makes sense to useAccountInterface
. - Merge request !37Issue #3378225: Replace AccountProxy with AccountInterface β (Merged) created by Liam Morland
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I just found your commits in the issue fork. They were not on the feature branch. I have put them on the feature branch and created a merge request. Please review that I did what you intended.
-
liam morland β
committed 5f0fea82 on 3.0.x
Issue #3378225: Replace AccountProxy with AccountInterface
-
liam morland β
committed 5f0fea82 on 3.0.x
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Looking at it again, I am satisfied that this is the correct change. Thanks!
-
liam morland β
committed e1cc9750 on 8.x-2.x
Issue #3378225: Replace AccountProxy with AccountInterface
-
liam morland β
committed e1cc9750 on 8.x-2.x
Automatically closed - issue fixed for 2 weeks with no activity.