Adjust icons to inherit color

Created on 29 July 2023, over 1 year ago
Updated 1 December 2023, about 1 year ago

Problem/Motivation

Icons have the background color #000000. Therefore in some color schemes, especially dark mode, they are not displayed properly.

Steps to reproduce

Use, e.g., dark mode in Gin Admin Theme.

Proposed resolution

Let icons inherit fill color.

Remaining tasks

Review MR.

📌 Task
Status

Fixed

Version

2.0

Component

User interface

Created by

🇩🇪Germany simonbaese Berlin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @simonbaese
  • @simonbaese opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇩🇪Germany simonbaese Berlin

    Adjusted the icons.

    Before:

    After:

  • Status changed to RTBC about 1 year ago
  • 🇮🇳India shyam_bhatt Gujarat

    @simonbaese I have checked the "MR !9", the accordion module icon on the CKEditor 5, visible in white with the GIN as admin them and visible in black with the GIN light theme.

    Please check the images below:

    Before MR:

    After MR:

    Moving to +RTBC.

  • Status changed to Fixed about 1 year ago
  • 🇫🇮Finland j-vee Turku, Finland

    Good catch - fixed in 2.1.0, thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024