- Issue created by @rhovland
- Status changed to Needs review
over 1 year ago 8:50am 30 July 2023 - last update
over 1 year ago 149 pass - 🇮🇱Israel jsacksick
Why not setting the patch to needs review? To see if tests are still passing? :)
- 🇺🇸United States rhovland Oregon
I was working on testing this, unless the automated tests passing is good enough.
I have completed testing it in my project. Should I test it on a stock install of commerce too? - last update
about 1 year ago 140 pass, 2 fail - 🇮🇱Israel jsacksick
I'm ok with this change, refreshing the whole form is going to be slower though, but that makes it more flexible for sure...
The last submitted patch, 2: 3377870-shipping-rate-widget-ajax-2.patch, failed testing. View results →
- 🇮🇱Israel jsacksick
hm... I'm not sure if the test failures are related... but the dev tests are passing.
- 🇫🇷France goz
I confirm this patch help when we have to refresh more than the two hard coded parts.
This helps me on https://www.drupal.org/project/commerce_shipping_mondial_relay/issues/34... 🐛 Refresh Mondial relay pane on shipping method changes Active .Another solution would be to dispatch an event on ajaxRefresh which could allow to alter ajaxResponse.
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Waiting for branch to pass - 🇫🇷France goz
Any update on this ?
What do you think about this patch ?
What about my proposal dispatching an event to alter ajaxResponse ? - 🇮🇱Israel jsacksick
Let's open an MR with the changes, to see if the tests are passing, if the initial proposed patch works, let's roll with it.
@rhovland: could you open an MR please? - Merge request !45Issue #3377870: ShippingRateWidget ajax refresh does not refresh other form elements → (Merged) created by rhovland
-
jsacksick →
committed df4a4505 on 8.x-2.x authored by
rhovland →
Issue #3377870 by rhovland, jsacksick, GoZ: ShippingRateWidget ajax...
-
jsacksick →
committed df4a4505 on 8.x-2.x authored by
rhovland →
- Status changed to Fixed
6 months ago 7:41am 30 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.