minor phpcs issues

Created on 28 July 2023, over 1 year ago
Updated 15 August 2024, 3 months ago

Problem/Motivation

Steps to reproduce

Execute phpcs command, phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme web/modules/menu_attributes

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ› Bug report
Status

RTBC

Version

1.2

Component

Code

Created by

šŸ‡®šŸ‡³India Shreya_98

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Shreya_98
  • šŸ‡®šŸ‡³India Shreya_98

    I had resolved the minor issues which occurred in this module.
    Go through with patch file and merge this changes in module code.

  • Issue was unassigned.
  • šŸ‡ŗšŸ‡øUnited States DCLoganGuy

    Hey,
    I downloaded 7.x-1.2. The only change I see in code is in the .info file. What php compatibility changes should be in this release?

    thanks

  • Status changed to Needs review 9 months ago
  • šŸ‡®šŸ‡³India chaitanyadessai Goa

    Please review patch.

  • Status changed to RTBC 3 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @chaitanyadessai,

    I applied patch#5, it was applied smoothly and fixed the phpcs issues.

    āžœ  menu_attributes git:(7.x-1.2) curl https://www.drupal.org/files/issues/2024-02-19/3377698-5.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 17820  100 17820    0     0  43927      0 --:--:-- --:--:-- --:--:-- 43891
    patching file CHANGELOG.txt
    patching file menu_attributes.api.php
    patching file menu_attributes.install
    patching file menu_attributes.module
    patching file menu_attributes.test
    āžœ  menu_attributes git:(7.x-1.2) āœ— ..
    āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml menu_attributes
    āžœ  contrib

    Thank you.

Production build 0.71.5 2024