Contrib.social

Old function calls or missing dependency?

Open on Drupal.org →
Created on 27 July 2023, over 1 year ago

First things first, nice idea. I remember a case where we had a need for this functionality but worked-around it another way.

Problem/Motivation

I checked the module's code and what troubled me is that you have used functions like drupal_mail() or variable_get. Is it code that was semi-refactored and needs more work for Drupal 9/10? Or maybe you developed it while having retrofit installed?

Because otherwise, drupal_mail() was removed by #2309379 → while variable_*() by #2183531 → .

💬 Support request
Status

Active

Version

1.0

Component

Code

Created by

🇬🇷Greece vensires

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @vensires
  • Assigned to Arlina
  • Comment over 1 year ago →
    🇺🇸United States Arlina

    Thanks for taking a look @vensires! I just uploaded the code yesterday so I'm happy it's getting some views. To answer, yes, this is a port of a custom D7 module (not using retrofit) so I'm still refining it. So far I've been developing against D9, but I'll be running it through a deprecation checker to make sure it's fully D10 compatible.
    I'm working on this for a couple of clients so I expect to have an alpha release in next couple of weeks. I'll make sure to incorporate your observations and hope to get more feedback in the future. Cheers!

  • Comment over 1 year ago →
    🇬🇷Greece vensires

    Thank you for your kind response! Looking forward for your first full release then :)
    Keep up the good work!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024