- Issue created by @cbeier
- 🇨🇦Canada mahde Vancouver
I fixed this by re-building the highlight.js file with the new version of "@ckeditor/ckeditor5-highlight": "~40.0.0" and "@ckeditor/ckeditor5-theme-lark": "~40.0.0", "ckeditor5": "~40.0.0" in the package.json file.
Hope to get this fixed in this module. Thanks!
- 🇮🇳India arisen Goa
I am getting the same error on Drupal 10.1.5. The fixes mentioned in #3 works perfectly fine.
Verified if the fixes are compatible with Drupal 9.5.11. It isn't working. Throwing errorTypeError: t.map is not a function at ue (ckeditor5-dll.js?v=35.4.0:5:447835) at Object.callback (highlight.js?s2rxpt:1:10856) at i.create (ckeditor5-dll.js?v=35.4.0:5:416819) at ckeditor5-dll.js?v=35.4.0:5:439488 at Array.map (<anonymous>) at X.fillFromConfig (ckeditor5-dll.js?v=35.4.0:5:439398) at c._initToolbar (js_tdNyFRf0JHNvXCd9Fmk2k0H7Dmb7NBLR0o8jbyDEUz4.js:4:6337) at c.init (js_tdNyFRf0JHNvXCd9Fmk2k0H7Dmb7NBLR0o8jbyDEUz4.js:4:5924) at js_tdNyFRf0JHNvXCd9Fmk2k0H7Dmb7NBLR0o8jbyDEUz4.js:4:9072
Checking if any possible fixes for both Drupal 9 and 10.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 3:23pm 2 November 2023 Created MR 2 https://git.drupalcode.org/project/ckeditor5_highlight/-/merge_requests/2 from @jmcintyre's commit.
- Status changed to Needs work
about 1 year ago 4:00pm 8 November 2023 - 🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7
I think we should match 10.1 core's ckeditor5 version, which is
39
And yes, that won't work for <10.1, so this have to go to
1.1.x
branch - Status changed to Needs review
about 1 year ago 7:41pm 8 November 2023 Changed package.json dependencies to version
39.0.0
, and target branch in the MR to1.1.x
. Looks like1.1.x
is behind1.x
right now, so can change target branch back if needed.Also, rebuilt the JS, but there's no difference between the 40 build and 39 build.
- 🇬🇧United Kingdom fonant
Using plain diff from MR 2 as a patch works to make the button work here :)
-
el7cosmos →
committed 8753a04f on 1.1.x authored by
godotislate →
Issue #3377086 by godotislate, jmcintyre, el7cosmos, cbeier, mahde,...
-
el7cosmos →
committed 8753a04f on 1.1.x authored by
godotislate →
- Status changed to Fixed
about 1 year ago 1:21pm 18 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.