- Issue created by @ericvl
- Assigned to sunidhinegi31
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @chetan-11 opened merge request.
- ๐ง๐ชBelgium ericvl
What a pitty the composer.json only specifies a required drupal/core of 8.* or 9.* and not version 10.*.
Is it possible to adapt this?
Thanks - ๐ฎ๐ณIndia chetan 11
Hi @EricVL, cann't add D10 version because module is not compatible with Drupal 10.
- ๐ง๐ชBelgium ericvl
@chetan 11
I know this module is not D10 compatible but adding a composer.json file should be part of making this module compatible with D10.
Therfore I've first added this requiest to this ๐ Automated Drupal 10 compatibility fixes Fixed issue but according to @jcnventura this was not the correct issue to ask for a composer.json.
Therfore i have made a new one - this one here.
So, could somebody add this composer.json file together with the solution to make this module D10 compatible, please.
Thank you - Status changed to Needs work
over 1 year ago 1:51pm 14 September 2023 - ๐ต๐นPortugal jcnventura
Please remove the "composer/installers": "^1.8" requirement, as that is not really needed by the theme. It is needed by the drupal project module that will take care of making sure that core and any modules/themes get installed to the right place.
- ๐ต๐นPortugal jcnventura
@EricVL, yes and this here should add the composer.json supporting only D8 and D9. The D10 issue should then make sure to add the D10 support to this file.
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 6:39am 15 September 2023 - Status changed to Needs work
about 1 year ago 10:57pm 18 October 2023 - ๐ต๐นPortugal jcnventura
Actually now that I've paid better attention to this, there is a lot here that should be removed. Namely:
- authors: Who is Lokesh Sahu? Please remove the entire section. This is better tracked in the drupal.org homepage of the theme
- repositories: not needed
- require: The whole section can be removed, as the drupal core support is injected by the drupal.org packagist from the information in the .info.yml file
Also, license must be a valid SPDX identifier (GPL-2.0-or-later).
-
jcnventura โ
committed c2722bef on 8.x-1.x
Issue #3377042 by chetan 11, jcnventura: Add composer.json
-
jcnventura โ
committed c2722bef on 8.x-1.x
- Status changed to Fixed
about 1 year ago 11:05pm 18 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.