Optimized Brotli files not served when CSS/JS aggregation enabled

Created on 25 July 2023, over 1 year ago

Updated 31 July 2023, over 1 year ago

It looks like AdvAgg is broken. I am using Drupal 9.5.10 on PHP 7.4.33 and tested with both version 6.0.0-alpha1 and 5.0.0.

By accident I discovered Brotli versions are not served to my browser.

After digging into this, it came out files in /sites/default/files/(js|css) were being served instead of the files inside /sites/default/files/(js|css)/optimized/.

When cleaning cache and regenerating all files it looks like AdvAgg is generating all optimized JS and CSS files well, as well as its Gzip and Brotli versions.

If I disable JS and CSS aggregation on the page /admin/config/development/performance, many CSS and JS files inside the optimized directory get being served as intended. However, if I re-enable both options to get the aggregation versions, it reverts to the files inside /sites/default/files/(js|css)

It looks like the bandwidth optimization aggregation logic in core somehow breaks AdvAgg.

🐛 Bug report

Status

Active

Version

6.0

Component

Code

Created by

sd123

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @sd123
Comment over 1 year ago →
sd123
Comment over 1 year ago →
🇺🇸United States recrit
@sd123 You are misunderstanding the purpose of the optimized files. See this comment for clarification - https://www.drupal.org/project/advagg/issues/3001984#comment-12923698 💬 Files in optimized directory not used Closed: duplicate
Comment over 1 year ago →
sd123
ok, but then there still is a bug: I have Brotli support installed. The optimized files all have Brotli versions because of this. However the aggregated files do not get a Brotli version. Probably because Drupal core does not support Brotli. This renders Brotli support in AdvAgg useless.

AdvAgg should somehow help Drupal to generate Brotli versions of the aggregated JS/CSS when Brotli is enabled.
Comment over 1 year ago →
sd123

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024