The 9401 and 9402 update hooks can make a Drupal 9 to 10 update fail

Thanks for filing the issue.

The assumption was that you made the update of the module before upgrading core, a direct upgrade of both at the same time has never been tested.

Looking at the test results, it looks like this is failing, if you do the update in Drupal 9. I guess because then the dependencies are not fulfilled, because there is no such user update hook, yet?

Looks like we need to work on this some more.

For now, I've added this as a known issue to the release notes. I'd also say this is a major issue.

I added a workaround that should fix this issue. However, the test failure looks like a core bug, so I'll file an issue in that issue queue.

Thanks! Test results look good now and the code looks good as well. I didn't realize that the fix would be that easy, I thought we might have to move everything to post update hooks, which might have had other problems, or work on the role config directly or something...

I'd like to give this some manual testing before I commit this, just in case, will do that later. Then I can hopefully also take a look at the MR for core, unless @smustgrave beats me to it ;).

Now had a chance to test the various upgrade paths manually and it seems to work as intended. RTBC.

Merged. Thanks again!

Automatically closed - issue fixed for 2 weeks with no activity.