Cannot apply patch Issue #2985882

Created on 23 July 2023, over 1 year ago
Updated 15 November 2023, about 1 year ago

Problem/Motivation

I'm trying Varbase update from 8.12 to 9.0.14

I've used this one file as the base one:
https://github.com/Vardot/varbase-project/blob/9.0.14/composer.json

In the final stage, when installing the patches there are 2 patches that are not applying

#1
https://www.drupal.org/files/issues/2020-01-20/2985882-53.patch (Issue #2985882: Fix Error: Call to a member function getLabel() after enabling layout_builder)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-01-20/2985882-53.patch

#2
https://www.drupal.org/files/issues/2021-10-29/3053881-60.patch (Issue #3053881: Reverting entity revisions that contain custom blocks erroneously triggers EntityChangedConstraint)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2021-10-29/3053881-60.patch

Steps to reproduce

Update 8.12 to 9.0.14 with composer install and using the composer.json from:
https://github.com/Vardot/varbase-project/blob/9.0.14/composer.json

Proposed resolution

As long as setting "composer-exit-on-patch-failure": false is not the best practice as a temporary solution I'm proposing to add to composer.json:

  "extra": {
	"patches-ignore": {
      "drupal/varbase_core": {
        "drupal/core": {
          "Issue #2985882: Fix Error: Call to a member function getLabel() after enabling layout_builder":
          "https://www.drupal.org/files/issues/2020-01-20/2985882-53.patch",
		  "Issue #3053881: Reverting entity revisions that contain custom blocks erroneously triggers EntityChangedConstraint":
          "https://www.drupal.org/files/issues/2021-10-29/3053881-60.patch"
        }
      }
	},

Of course, it needs more investigation - why those patches are not applying (maybe they are already in core?)

🐛 Bug report
Status

Fixed

Version

9.0

Component

Code

Created by

🇬🇪Georgia almador

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024