Custom builder class not being used

Thanks, this was a change from 1.x-2.x where the definition types changed from being an array to a definition Object.

I did notice this for some other properties, but looks like I missed this one. For the short term I'm going to implement this fix, but long term I'm going to look at implementing a IconsetDefinition class with the iconset properties clearly defined.

Will provide the short term update this in the next day or so.

Thanks

Sounds good. Here's a patch and a PR :)

Thanks for the PR.

I'll also write some tests soon to validate the custom builders are being called (and other properties) for future fixes.

I'm also going to push a couple fixes to the StrategyDefinition in Toolshed, to implement the `__isset()` method which is a good call out from you.

Automatically closed - issue fixed for 2 weeks with no activity.