- Issue created by @mondrake
- last update
over 1 year ago 29,638 pass, 60 fail - @mondrake opened merge request.
- last update
over 1 year ago 29,638 pass, 60 fail - last update
over 1 year ago 29,826 pass - Status changed to Needs review
over 1 year ago 4:56pm 20 July 2023 - 🇮🇹Italy mondrake 🇮🇹
Simple change. It's not worth adding a convenience method in Connection in this case, since the Tasks class gets instantiated directly without connection by the installation routines. Could think of a static method, but that would be a bigger change.
- Status changed to RTBC
over 1 year ago 5:53pm 20 July 2023 - 🇳🇱Netherlands daffie
All code changes look good.
Just one more class added to the conditional deprecation ofConnection::getDriverClass
For me it is RTBC.The following text needs to be added to the CR:
The replacement for the database class "Install\Tasks" is:
// Before $class = Database::getConnection()->getDriverClass('Install\\Tasks'); // Replacement $class = Database::getConnection()->getConnectionOptions()['namespace'] . '\\Install\\Tasks';
-
longwave →
committed e8073004 on 11.x
Issue #3375919 by mondrake, daffie: Deprecate usage of Connection::...
-
longwave →
committed e8073004 on 11.x
- Status changed to Fixed
over 1 year ago 9:47am 22 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.