- Issue created by @carolpettirossi
- last update
almost 2 years ago 5 pass - @carolpettirossi opened merge request.
- 🇧🇷Brazil carolpettirossi Campinas - SP
Attaching .patch to use with composer.json
MR is ready to review. Note that the code only works if the messages div has "role=alert"
- Status changed to Needs review
almost 2 years ago 9:07pm 25 September 2023 - last update
almost 2 years ago 5 pass - Status changed to RTBC
almost 2 years ago 4:11am 26 September 2023 - 🇵🇭Philippines Zed9
Hi @carolpettirossi I've reviewed your patch (3375915-creating_block_form_errors_scroll-3.patch) and can confirm the modal scrolls up when an error on the form occurs. Please refer to the attached image for reference. Appreciate your efforts!
- Status changed to Needs work
over 1 year ago 5:53pm 28 December 2023 - 🇺🇸United States kmonty San Francisco, CA & Berlin, DE
Minor change, but the `once` dependency should be included in the wrapper function.
So:
(function (Drupal, drupalSettings) { [...] })(Drupal, drupalSettings);
becomes:
((Drupal, drupalSettings, once) => { [...] })(Drupal, drupalSettings, once);
Also, this should be run through eslint, as it doesn't match Drupal's Prettier rules (single quotes instead of double quotes, no unnamed funcs, incomplete code comments
// If no error messages exist, the
etc.) - Status changed to Needs review
over 1 year ago 5:07am 29 December 2023 - last update
over 1 year ago Patch Failed to Apply - 🇮🇳India shalini_jha
Hi, I have updated the changes in this patch. please review.
- Status changed to Needs work
over 1 year ago 6:28am 30 December 2023 - 🇺🇸United States kmonty San Francisco, CA & Berlin, DE
The new patch is just for my suggested changes against the 8.x branch and not updating the existing patch. It also does not include eslint changes.
- First commit to issue fork.