- Issue created by @justcaldwell
- First commit to issue fork.
- 🇺🇸United States justcaldwell
@sakthi_dev Note that I opened the issue and assigned it to me. That means I'm actively working on it.
- Status changed to Needs review
12 months ago 3:17pm 19 July 2023 - Status changed to Active
12 months ago 3:23pm 19 July 2023 - @justcaldwell opened merge request.
-
justcaldwell →
committed 3683f2e4 on 2.0.x
Issue #3375606 by justcaldwell: Drupal 10 compatibility
-
justcaldwell →
committed 3683f2e4 on 2.0.x
- Status changed to Fixed
12 months ago 9:28pm 19 July 2023 - 🇺🇸United States justcaldwell
Drupal 10's approach to the off-canvas CSS reset is much cleaner, but it was revertinglow-specificity user styles that worked in Drupal 9.
Rather than requiring end-users to add more specificity to styles (e.g. with
!important, or adding#drupal-off-canvas-wrapper .userstyle), I opted to implementhook_selector_library_info_alter()to 'disable' core's off-canvas reset. I added a replacement to style_selector.libraries.yml, which is an exact copy, except it adds.ssui__optionelements to the list of elements excluded from the reset.So, core's rule:
#drupal-off-canvas-wrapper *:where(:not(svg, svg *, .ck-reset *, [data-drupal-ck-style-fence] *, .ui-resizable-handle))becomes:
#drupal-off-canvas-wrapper *:where(:not(svg, svg *, .ck-reset *, [data-drupal-ck-style-fence] *, .ui-resizable-handle, .ssui__option)) - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.