Remove "core: 8.x" from the .info.yml file

Hello Maintainers,
I have provided a patch to fix this issue.
Please review it.

Thanks!

-core: 8.x
 core_version_requirement: ^8 || ^9 || ^10

Since core is removed, core_version_requirement needs to be changed to core_version_requirement: ^8.8 || ^9 || ^10. Earlier Drupal 8 releases do not recognize core_version_requirement; the module is not installable on those releases, if it uses just core_version_requirement.

The MR contains changes that are not related to this issue.

The patch is not correct.

 core: 8.x
-core_version_requirement: ^8 || ^9 || ^10
+core_version_requirement: ^8.8 || ^9 || ^10

Since core_version_requirement is changed, core must be removed.

Also, did anybody check the same branch of this module can be used with Drupal 8, Drupal 9, and Drupal 10?
I find it hard to believe, since there are functions/methods/services implemented in Drupal 8 which have been removed in Drupal 10. Even in the case a method/function has not been removed, its parameters could have been changed in a way that is not backward compatible.

Furthermore, what the module is actually using is perfectly fine: core: 8.x can be used with core_version_requirement: ^8 || ^9. It is when core_version_requirement does not have that value that core cannot be anymore used.

core: 8.x
core_version_requirement: ^8 || ^9

See New 'core_version_requirement' key in info.yml files for modules, themes and profiles allows Composer semantic version constraints including specifying multiple major versions of core → , which states:

For example a module that is compatible with Drupal 8 and Drupal 9 can have a info.yml file like this

Name: My Module
type: module
core: 8.x
core_version_requirement: ^8 || ^9

Removing core: 8.x is not necessary, if the maximum Drupal version required from the module to work is not changed.

If the proposed task is making the module installable on Drupal 10, the issue title should be changed and the patch/MR should also remove every call to functions/methods that have been removed in Drupal 10, if calls to such functions/methods exist.
It does not seem this has been verified.

@apaderno, The core key is removed now please check the commit 239ce263.
Put in the issue in needs review again please review.

This is a change only maintainers can decide to do.
It has been introduced the compatibility with Drupal 10, but I doubt maintainers wants to keep the code compatible with three different Drupal versions.

Also, nothing is wrong in using core: 8x together core_version_requirement: ^8 || ^9. Drupal core allows it and it is also shown in New 'core_version_requirement' key in info.yml files for modules, themes and profiles allows Composer semantic version constraints including specifying multiple major versions of core → , which states:

For example a module that is compatible with Drupal 8 and Drupal 9 can have a info.yml file like this

name: My Module
type: module
core: 8.x
core_version_requirement: ^8 || ^9

laboratory.mike → made their first commit to this issue’s fork.

I'm starting to do some updates for VAR, and went ahead and included the existing commits and move to support D9/D10 in the 2.0.x version. Thanks all for the feedback and working through this.

Automatically closed - issue fixed for 2 weeks with no activity.