- Issue created by @bijiaxing
- last update
about 1 year ago 65 pass, 4 fail In #2 there is a test-case failure So, Adding a updated patch for fixing failure test-cases. Attached the patch plz review.
- last update
about 1 year ago 68 pass - Status changed to Needs review
about 1 year ago 10:36am 19 July 2023 Hi kushagra.goyal
I found the same problem, thanks for your new patch.- last update
about 1 year ago Composer require failure - 🇨🇦Canada adam-vessey PE, Canada
Gave #3 a spin, and it seems to work, here. Thanks!
- Status changed to RTBC
11 months ago 3:13am 24 October 2023 - 🇮🇳India heykarthikwithu Bengaluru 🌍
#3 Patch file fixes the issue of
Deprecated function: Creation of dynamic property Drupal\features\FeaturesGenerationMethodManager::$cacheKeyPrefix is deprecated in Drupal\features\FeaturesGenerationMethodManager->__construct() (line 28 of modules/contrib/features/src/FeaturesGenerationMethodManager.php).Moving to RTBC.
- 🇺🇸United States dave reid Nebraska USA
Dave Reid → made their first commit to this issue’s fork.
- Status changed to Needs review
10 months ago 5:58pm 8 December 2023 - 🇺🇸United States dave reid Nebraska USA
Looking at the code I don't actually see cacheKeyPrefix used anywhere in the class or its parent class, DefaultPluginManager. I believe we can just remove it because $this->cacheKey is the prefix.
- Merge request !34Remove FeaturesGenerationMethodManager::cacheKeyPrefix for PHP 8.2 compatibility. → (Merged) created by dave reid
- Status changed to RTBC
10 months ago 6:05pm 8 December 2023 - 🇺🇸United States dave reid Nebraska USA
Confirmed all tests passing now where they weren't before, merging the MR.
-
Dave Reid →
committed 788cfa3e on 8.x-3.x
Issue #3375425 by Dave Reid, kushagra.goyal, bijiaxing: Fixed PHP 8.2...
-
Dave Reid →
committed 788cfa3e on 8.x-3.x
- Status changed to Fixed
10 months ago 6:11pm 8 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.