Avoid invoking global services in the controller files

Created on 18 July 2023, 11 months ago

Updated 22 September 2023, 9 months ago

Problem/Motivation

Both the controller files invoke global calls to 1) the messenger service and 2) the tempstore.shared service. PHPCS reports the DI error for both of them.

Steps to reproduce

Proposed resolution

Inject the services into the class via DI.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

1.10

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Comments & Activities

Issue created by @sidharth_soman
Issue was unassigned.
Status changed to Needs review 11 months ago8:19pm 18 July 2023
Comment 11 months ago →
🇮🇳India sidharth_soman Bangalore
I have solved the issue. Please review the patch
Comment 9 months ago →
🇺🇸United States glynster
Thanks so much for your contribution, @sidharth_soman. Your patch was included in our latest release.
Status changed to Fixed 9 months ago6:02pm 22 September 2023
Comment 9 months ago →
🇺🇸United States glynster

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024