- Issue created by @tomsaw
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @tomsaw opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - Status changed to Postponed: needs info
about 1 year ago 4:27pm 25 September 2023 - 🇮🇹Italy itamair
Hey TomSaw ... it looks that MR !34 is not mergeable and is indeed adding a lot of additional changes out of not relevant with) the context of this issue.
Such in the following files:
- doc/drupal_org_documentation/description.html
- modules/geocoder_address/src/AddressService.php
- etc ...Didn't you notice and review your MR?
Please provide something that is indeed rebased to last stable Geocoder 8.x-4.9 release ...
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Not currently mergeable. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Not currently mergeable. - last update
11 months ago 4 pass - 🇩🇪Germany tomsaw Essen
Oh darn. Since im a newby with gitlab and huge repos.. i had some trouble with the rebasing.
I first thought the MR was on 8.x-4.x.. However. now it looks good to me
- Status changed to Needs review
11 months ago 2:59pm 2 November 2023 - Status changed to RTBC
10 months ago 8:55pm 27 November 2023 - 🇬🇧United Kingdom dwkitchen London
Reviewed and tested, works as described.
However, could we not add GeocoderBaseFieldDefinition and GeocoderBundleFieldDefinition to the Geocoder module, rather than having to define them in our custom modules?
- 🇩🇪Germany tomsaw Essen
Please view the changes for this MR @dwkitchen.
I have not defined
GeocoderBaseFieldDefinition
/GeocoderBundleFieldDefinition
in a custom module.All that was needed was to release/adjust some type checks down the inheritance chain for
FieldConfigInterface
. What goes into your custom module - to use this MR's feature - is your custom entity-type as it should be!