Refactor SPA code base to reduce redundant REST API calls

Issue created by @Ryo Yamashita
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
@ryo-yamashita opened merge request.
Status changed to Needs review almost 2 years ago3:31am 18 July 2023
Comment almost 2 years ago →
🇯🇵Japan Ryo Yamashita
@yas

Please review it. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Status changed to Needs work almost 2 years ago7:03am 18 July 2023
Comment almost 2 years ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the refactor. Alert Message should be Status Message.
Please consider the guard clause in the entire logic. Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Status changed to Needs review almost 2 years ago12:25am 19 July 2023
Comment almost 2 years ago →
🇯🇵Japan Ryo Yamashita
@yas

I pushed patches for your comments. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
6:56
4:44
Running
Status changed to Needs work almost 2 years ago4:51am 19 July 2023
Comment almost 2 years ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the update. I posted my comments. Thanks!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Comment almost 2 years ago →
🇺🇸United States yas California 🇺🇸
Status changed to Needs review almost 2 years ago6:47am 19 July 2023
Comment almost 2 years ago →
🇯🇵Japan Ryo Yamashita
Status changed to Needs work almost 2 years ago7:27am 19 July 2023
Comment almost 2 years ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the update. It looks getting cleaner. I posted my minor comments. Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Status changed to Needs review almost 2 years ago8:15am 19 July 2023
Comment almost 2 years ago →
🇯🇵Japan Ryo Yamashita
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Comment almost 2 years ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
366 pass
Comment almost 2 years ago →
System Message

yas → committed 047ce464 on 6.x authored by Ryo Yamashita →
Issue #3375128 by Ryo Yamashita, yas: Refactor SPA code base to reduce...
Status changed to RTBC almost 2 years ago10:01am 19 July 2023
Comment almost 2 years ago →
System Message

yas → committed 80a68244 on 5.x authored by Ryo Yamashita →
Issue #3375128 by Ryo Yamashita, yas: Refactor SPA code base to reduce...
Status changed to Fixed almost 2 years ago10:02am 19 July 2023
Comment almost 2 years ago →
🇺🇸United States yas California 🇺🇸
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Refactor SPA code base to reduce redundant REST API calls

Problem/Motivation

Comments & Activities