Node storage cache is completely reset on every cron run

Created on 17 July 2023, over 1 year ago

Updated 17 October 2023, about 1 year ago

Problem/Motivation

node_access_rebuild_progressive_process_chunk() calls resetCache() without any argument. This clears the whole storage cache.
It should probably clear it only for the nodes it is currently processing because this means that the cache will be cleared every minute or so until all nodes have been processed.

(Also, shouldn't it be called before loading the nodes? That's what node_access_rebuild() does.)

I see this was introduced in order to try fixing #3080473: Running out of memory → but the solution ended up being something else?

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @prudloff
@prudloff opened merge request.
Assigned to shelane
Status changed to Needs review about 1 year ago5:09am 13 October 2023
Comment about 1 year ago →
🇺🇸United States shelane
Comment about 1 year ago →
System Message

shelane → committed b1fddeca on 2.x authored by prudloff →
Issue #3374977 by prudloff: Node storage cache is completely reset on...
Issue was unassigned.
Status changed to Fixed about 1 year ago2:26pm 17 October 2023
Comment about 1 year ago →
🇺🇸United States shelane
Thanks
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024