- Issue created by @obomevelhomax
- Status changed to Needs work
about 1 year ago 12:00am 23 August 2023 - 🇬🇧United Kingdom rivimey
I apologise for not getting the translation right already and thank you for your work on this.
However, the patch here has a lot of changes and while I can see some are related to translation, some are definitely not. In addition, the replacement for the config/install views file seems to be quite different from the original, not merely an update.
Could you clean up the patch somewhat? strip out anything not necessary for the translation to work, and rework the config/install file to be a minimal update also? It would be easier for me to check if there were several patches that grouped the different sorts of change, even if they all need applying at once.
My last concern is that I see the base table name is changed. I presume this is a necessary thing, although I have no idea why it would matter. This change would seem to at least minimally require an update hook to adjust existing installations. There are perhaps other changes that require an update hook's intervention also?
Finally, note that the 2.x branch is now on security-fixes only - it exists purely for those not willing to change from google_secrets.
- Status changed to Postponed: needs info
8 months ago 4:06pm 18 March 2024