- Issue created by @johnv
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
12 months ago Waiting for branch to pass - @sakthi_dev opened merge request.
- Status changed to Needs review
12 months ago 7:47am 14 July 2023 - Status changed to Needs work
12 months ago 6:21pm 14 July 2023 - 🇺🇸United States mlncn Minneapolis, MN, USA
Sympathetic to this despite how gratingly painful "Workflows Buttons" is to say and hear, but either way i think it's more important to specify explicitly that the buttons act on a workflow defined by the core module, not contrib.
On that has anyone succinctly written up why a sitebuilder should pick contrib Workflows module? ⅔ of its reported installations are from before Drupal 8; when Workflow Buttons was created it wasn't clear that it would even be ported to modern Drupal. This comment, https://www.drupal.org/project/workflow/issues/2852293#comment-15090752 💬 Is Workflow redundant now that Content Moderation+Workflows is in core? Active is accurate and complete?
- 🇺🇸United States beunerd Providence, Rhode Island
@sakthi_dev @mlncn
Won't this be a headache for existing drupal installations?
- 🇺🇸United States mlncn Minneapolis, MN, USA
Yeah there is no practical way to change the machine name.
Not convinced to change the display name either but open to it.
- 🇯🇵Japan ultrabob Japan
I think @mlncn is right, that the most important place for this to be clear would be the project page on Drupal.org, and maybe in the README. Changing the display name or the module name would be a lot more pain for those already familiar with the module, than any conceivable benefit for potential new users looking for workflow or workflows compatible modules.
- Status changed to Needs review
8 months ago 6:30pm 2 November 2023 - 🇯🇵Japan ultrabob Japan
I propose a maintainer make a call on what to do here, and get the ticket closed.
My proposal:
Change the first paragraph on the drupal.org module description from
Provides buttons for content moderation, with each button based on configured workflow transitions, instead of a select dropdown of states.
to
This module works with the core workflows module to provide buttons for content moderation. Each button is based on configured workflow transitions and replaces the default user experience of selecting from a dropdown of states before saving.
- Status changed to RTBC
7 months ago 4:06am 13 December 2023 - 🇯🇵Japan ultrabob Japan
I see the description has been updated. Thank you, I think that does enough to clear this issue up.
- Status changed to Fixed
7 months ago 4:12am 13 December 2023 - 🇺🇸United States mlncn Minneapolis, MN, USA
Yes, updated the module description. Thanks all!
Automatically closed - issue fixed for 2 weeks with no activity.