Remove requirement for geocoding and geolocation modules by default

Created on 13 July 2023, over 1 year ago
Updated 23 October 2023, about 1 year ago

Original title:
Why are geocoding and geolocation modules required to show modals?

Background:
when the module was originally created it was for a client who wanted to target audiences for specific modals by geographic region/state...we decided to publish it for others to use and I guess we never went back to adjust this to only require the geolocation module if you have the geolocation settings enabled.

Proposed resolution:
Look into removing the default requirement and only conditionally require the modules if use of geolocation targeting is desired. Perhaps moving it to a submodule.

πŸ› Bug report
Status

Closed: cannot reproduce

Version

5.1

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States kevinquillen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kevinquillen
  • Assigned to rosemarystanley
  • πŸ‡ΊπŸ‡ΈUnited States rosemarystanley

    Hello! So when the module was originally created it was for a client who wanted to target audiences for specific modals by geographic region/state...we decided to publish it for others to use and I guess we never went back to adjust this to only require the geolocation module if you have the geolocation settings enabled. So I'm marking this as a minor bug to fix and conditionally require the module if you want to use geolocation targeting for modals.

  • Status changed to Postponed: needs info over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States rosemarystanley

    Hello! I'm taking a look at this and I'm a little confused. Where are you seeing the geolocation / geocoder module requirement? I'm not seeing any requirement for those modules. There are some APIs that help with getting a user's geolocation from the IP address but that does not require any additional module. I thought I had hard coded something from those modules but I'm not finding anything that requires it. Are you getting an error message or something?

  • Status changed to Closed: cannot reproduce about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States rosemarystanley

    Closing due to inactivity and no response. Feel free to reopen if need be. Thanks!

Production build 0.71.5 2024