- Issue created by @sebaz
- Status changed to Postponed: needs info
about 1 year ago 10:22am 9 November 2023 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
Did you check what will happen when no admin label is set? Or is it always available?
- 🇵🇱Poland sebaz
You don't need to check the admin label existance. Take a look at adminLabel() method implementation.
- Status changed to Needs review
about 1 year ago 3:43pm 9 November 2023 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
Great answer! Did not check the methods. Setting back to Needs Review. Looks great tho but need to have some time testing this. Or someone else can?
- 🇵🇹Portugal dubois
@tim-diels, we've been using this for a while and works as expected.
-
tim-diels →
committed 1e68c57d on 1.0.x authored by
SebaZ →
Issue #3374382 by SebaZ, tim-diels, dubois: Change label of arguments (...
-
tim-diels →
committed 1e68c57d on 1.0.x authored by
SebaZ →
-
tim-diels →
committed 0505cfa3 on 1.2.x authored by
SebaZ →
Issue #3374382 by SebaZ, tim-diels, dubois: Change label of arguments (...
-
tim-diels →
committed 0505cfa3 on 1.2.x authored by
SebaZ →
- Status changed to Fixed
about 1 year ago 2:06pm 23 November 2023 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
Thank you both for the nice addition to this module. I added it to both branches (1.0.x and 1.2x). Will be included in next release.
Automatically closed - issue fixed for 2 weeks with no activity.