- Issue created by @Anybody
- π¨π¦Canada star-szr
Thanks for all the issues etc @Anybody!
Indeed there is a todo for this, MRs/patches welcome or I will try to add it for the next alpha: https://git.drupalcode.org/project/ckeditor5_paste_filter/-/blob/daaef41...
- π¨π¦Canada star-szr
Iβm of course open to other improvements but just making the title more specific and updating the component.
- π¨π¦Canada star-szr
Hmm, I missed that the other form issue is a child issue of this but unless we create another child issue I think this makes sense.
We could create a βPlanβ type issue if there are even more suggestions and group them all under that.
- π©πͺGermany Anybody Porta Westfalica
Yes I agree, the new title is more clear!
- last update
over 1 year ago Build Successful - @anybody opened merge request.
- Status changed to Needs review
over 1 year ago 8:14am 13 July 2023 - π©πͺGermany Anybody Porta Westfalica
Here we go, but in my tests it doesn't work well yet, I think it's an issue with the AJAX replacement. Perhaps a bug in States API or I made a mistake... ideas?
- π¨π¦Canada star-szr
Thanks @Anybody!
This might be a core bug with #states and AJAX, I found π Display Bug when using #states (Forms API) with Ajax Request Needs work . I tried testing patches from there on 9.5.x π Display Bug when using #states (Forms API) with Ajax Request Needs work and 10.1.x π Display Bug when using #states (Forms API) with Ajax Request Needs work but didn't find anything workable.
- Status changed to Needs work
over 1 year ago 10:53am 13 July 2023 -
star-szr β
committed e877014d on 1.0.x
fix: better interface text for plugin enabled checkbox References: #...
-
star-szr β
committed e877014d on 1.0.x
-
star-szr β
committed 2f565136 on 1.0.x
fix: hide plugin configuration when plugin is not enabled Fixes: #...
-
star-szr β
committed 2f565136 on 1.0.x
- Status changed to Fixed
over 1 year ago 8:23pm 21 August 2023 - π¨π¦Canada star-szr
I have implemented this just using some
#access
logic since the form gets reloaded with AJAX when you toggle the checkbox.I also updated the interface text for the checkbox to try to be more clear:
- π¨π¦Canada star-szr
I forgot to mention in my previous comment I also tested this without JavaScript and it works fine. There is an extra step involved if you want to enable the plugin and then customize the filters, but even without JavaScript it's more clear whether the filters are active or not.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
5 months ago 9:18pm 1 July 2024