- Issue created by @markie
- last update
over 1 year ago 10 pass, 1 fail - Assigned to roshni27
- Issue was unassigned.
- 🇮🇳India roshni27
I have review above MR in that 1 error of unused statement . I have remove unused statement and upload the patch.
please review it. - last update
over 1 year ago Patch Failed to Apply - last update
about 1 year ago 10 pass, 1 fail - Status changed to Needs review
about 1 year ago 5:09pm 12 October 2023 - last update
about 1 year ago 10 pass, 1 fail - last update
about 1 year ago 11 pass - 🇺🇸United States markie Albuquerque, NM
in the test fix, the expected_build array changes to the html instead of the cache, which is requested after we switch to the stark theme. This sets a different variable for the to expected arrays and the tests pass.
- First commit to issue fork.
- last update
12 months ago 11 pass - 🇷🇺Russia Chi
This is not a bug. The behavior is documented in Cheat Sheet and in \Drupal\twig_tweak\View\RegionViewBuilder::build(). Though I think switching to active theme as default value makes sense.
The remaining tasks.
1. Update documentation
2. Remove unused $configFactory dependency from RegionViewBuilder service.The main concern here is BC break. We probably should postpone this change for the next major TT release.
- Status changed to Postponed
12 months ago 9:32am 5 January 2024