Contrib.social

Add the Gin dark mode to the Drupal off canvas for Layout Builder. Even tho if the user was using the Gin light mode at the back-end

Open on Drupal.org →
Created on 11 July 2023, over 1 year ago
Updated 10 September 2023, over 1 year ago

Problem/Motivation

Having a light mod Layout Builder off canvas, with dark mixed mode

→

→

→

Proposed resolution

  • Add an only administrative behavior to add the Gin dark mode to the Drupal off canvas.
  • Even tho if the user is using the Gin light mode.

Add the gin--dark-mode class to the #drupal-off-canvas or #drupal-off-canvas-wrapper only once.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 10.0.0-beta1 → , varbase_layout_builder-10.1.0-alpha6 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

→

→

→

→

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3373881 → : Added the Gin dark mode to the Drupal off canvas for Layout Builder. Even tho if the user was using the Gin light mode at the back-end
🐛 Bug report
Status

Fixed

Version

10.1

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024