Inconsistency in height of Homepage Slider

Created on 11 July 2023, over 1 year ago
Updated 11 May 2024, 11 months ago

Problem/Motivation: The Homepage slider has an inconsistent height if multiple images have been uploaded with different sizes.
Steps to reproduce:
Go to -> business_responsive_theme/images/slider folder and add images of different sizes.
Go to -> business_responsive_theme/config/install/business_responsive_theme.settings.yml file and add the details of images added in
the slider folder
On the landing page issue can be found.
I am attaching a video for the reference of the existing issue.

🐛 Bug report
Status

Closed: works as designed

Version

1.0

Component

Code

Created by

🇮🇳India lokeshsahu Delhi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @lokeshsahu
  • 🇮🇳India lokeshsahu Delhi

    Working on the issue and will create a patch to fix

  • Status changed to Needs review over 1 year ago
  • 🇮🇳India lokeshsahu Delhi

    I have created a patch to address the above issue. I am attaching a video for reference, showing the state before and after applying the patch.

  • Assigned to jay jangid
  • Issue was unassigned.
  • Status changed to RTBC over 1 year ago
  • 🇮🇳India jay jangid Jaipur

    I have reviewed and implemented the patch provided by @lokeshsahu.
    The patch has been implemented successfully.

    Here are the steps I took to reproduce the issue
    1. Installed Business Responsive Theme using composer
    2. Added some images of different sizes:-
    Go to -> business_responsive_theme/images/slider folder.
    3. Added the details of images added in the slider folder:-
    Go to -> business_responsive_theme/config/install/business_responsive_theme.settings.yml
    4. Cleared the caches or press ctrl + F5.

    I am sharing my videos for your reference.
    Result:-Height of the Homepage Slider is equal now.
    So moving it to RTBC +.
    Thank You.

  • Status changed to Closed: works as designed 11 months ago
  • It is recommend to hard code the image height and this has to handled in the image size.

Production build 0.71.5 2024