Fix the issues reported by phpcs

Created on 11 July 2023, 12 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/watchdog_watchdog/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 95 characters
19 | WARNING | Line exceeds 80 characters; contains 257 characters
21 | WARNING | Line exceeds 80 characters; contains 244 characters
26 | WARNING | Line exceeds 80 characters; contains 200 characters
39 | WARNING | Line exceeds 80 characters; contains 256 characters
46 | WARNING | Line exceeds 80 characters; contains 365 characters
48 | WARNING | Line exceeds 80 characters; contains 107 characters
----------------------------------------------------------------------

FILE: ..._cont/watchdog_watchdog/src/WWatchdogDisplayer/WWatchdogCommandLineDisplayer.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
25 | ERROR | Unknown type hint "mixed" found for $item
--------------------------------------------------------------------------------------

Time: 483ms; Memory: 10MB

Steps to reproduce

Execute: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig watchdog_watchdog/

Remaining tasks

Patch review

📌 Task

Status

Closed: works as designed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Comments & Activities

Issue created by @urvashi_vora
Status changed to Closed: works as designed 12 months ago7:13pm 11 July 2023
Comment 12 months ago →
🇨🇦Canada alberto56
Mixed is a valid type in PHP 8 as per https://php.watch/versions/8.0/mixed-type and in its watchdog_watchdog.info.yml this module declares it is PHP 8 dependent, so I think we're good there.

Also, I'm not sure about keeping markdown lines to 80 characters. According to https://stackoverflow.com/questions/29955688/in-markdown-is-there-an-off..., "There is no best practice for wrapping in Markdown. The only mention of wrapping in the original spec says that hard wrapping is permitted:", not _required_.

Unless we have a compelling reason to wrap to 80 lines, I prefer to keep it as is.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024