\Drupal calls should be avoided in classes, use dependency injection instead

Created on 11 July 2023, over 1 year ago

Updated 7 February 2024, 11 months ago

Problem/Motivation

FILE: .../summary_only/src/Plugin/Field/FieldFormatter/TextSummaryOnlyFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
85 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

Time: 104ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig summary_only/

Remaining tasks

Patch review

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Comments & Activities

Issue created by @urvashi_vora
Status changed to RTBC over 1 year ago6:51am 13 July 2023
Comment over 1 year ago →
🇵🇭Philippines kenyoOwen
Hi urvashi_vora

I applied your patch and confirmed that it removes the dependency injection issue mentioned above. Please see the screenshots attached.

Thank you.
Status changed to Fixed 11 months ago10:58am 24 January 2024
Comment 11 months ago →
🇮🇳India manishsaharan New Delhi
Thanks @urvashi_vora for finding and fixing the issue.
The issue is fixed and pushed.
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024