Bot instructions don't say when we can close the bot issue

Created on 10 July 2023, over 1 year ago
Updated 3 April 2024, about 1 year ago

Problem/Motivation

The instructions posted in the bot issue say to keep it open to keep getting patches:

> If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

But now D10 is released, should it be closed? The instructions don't say!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @joachim
  • πŸ‡­πŸ‡ΊHungary GΓ‘bor Hojtsy Hungary

    The instructions can't predicts if there will be increased deprecated API coverage or bugs fixed in the rector or phpstan rules, so it can't tell you if there is definitely not going to be any more fixes posted. It is up to you when you feel good enough about your own project compatibility. Should that explicitly be called out in the text?

  • πŸ‡¬πŸ‡§United Kingdom joachim

    Could there be more D10 update patches now that D10 is released?

    Or will the bot post D11 update patches to that same issue?

  • πŸ‡­πŸ‡ΊHungary GΓ‘bor Hojtsy Hungary

    The bot will not post Drupal 11 compatibility patches to the issues it opened with the "ProjectUpdateBotD10" tag (titled "Automated Drupal 10 compatibility fixes", although the title does not matter in matching).

  • πŸ‡¬πŸ‡§United Kingdom joachim

    Ok, so at what point will the D10 bot stop looking for issues to post patches to? That's what the issue text needs to tell maintainers.

  • πŸ‡­πŸ‡ΊHungary GΓ‘bor Hojtsy Hungary

    I don't think we know that yet, @bbrala is working on integrating the bot into project_analysis instead of a one-off github project and I don't know if all work is halted for good on Drupal 9 to 10 deprecated API related code.

  • πŸ‡­πŸ‡ΊHungary GΓ‘bor Hojtsy Hungary

    Also moving to the specific queue.

  • πŸ‡¬πŸ‡§United Kingdom joachim

    > I don't think we know that yet

    Ok so maybe the instructions that the bot posts to an issue should have a link to somewhere that has latest status of the bot, such as whether it's still running or has been retired.

    I'd suggest the bot's user profile page -- but that produces a 500 error!!!!

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    Fair enough. The goal is that the bot wil never stop running. We are currently working on getting d11 readiness up and running. See #3371547: [PLAN] Project update bot: road to Drupal 11 β†’ . This will be new issues though.

    Also there are still fixes that might emerge since we don't have full d9 coverage yet. So it might add more.

    To be honest, I would probably keep the bot running for d10 for a while, even until after d11 is released.

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    My current view is the following:

    The bot will run analyzing all project that support a supported version of drupal. Do we need anything more in this issue?

  • πŸ‡¬πŸ‡§United Kingdom joachim

    Do the bot instructions say that?

    What about the ProjectUpdateBotD10 tag -- will there be an 11 tag, or a generic 'latest' tag?

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    There is a ProjectUpdateBotD11 tag yeah.

Production build 0.71.5 2024