Fix the issues reported by phpcs

FILE: /home/lenovo/d7to9/web/modules/contrib/best_selling_products/src/Plugin/Block/BestSellingProductsBlock.php ------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 10 WARNINGS AFFECTING 14 LINES ------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Core\Entity\EntityTypeBundleInfoInterface. 153 | ERROR | [x] Expected 1 space after IF keyword; 0 found 153 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 178 | WARNING | [ ] #options values usually have to run through t() for translation 179 | WARNING | [ ] #options values usually have to run through t() for translation 180 | WARNING | [ ] #options values usually have to run through t() for translation 181 | WARNING | [ ] #options values usually have to run through t() for translation 182 | WARNING | [ ] #options values usually have to run through t() for translation 183 | WARNING | [ ] #options values usually have to run through t() for translation 184 | WARNING | [ ] #options values usually have to run through t() for translation 185 | WARNING | [ ] #options values usually have to run through t() for translation 186 | WARNING | [ ] #options values usually have to run through t() for translation 187 | WARNING | [ ] #options values usually have to run through t() for translation 189 | ERROR | [x] Use null coalesce operator instead of ternary operator. 196 | ERROR | [x] Use null coalesce operator instead of ternary operator. ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/best_selling_products/src/Service/ProductsServiceInterface.php ----------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------- 7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 16 | ERROR | Parameter tags must be grouped together in a doc comment 19 | ERROR | Parameter tags must be grouped together in a doc comment ----------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/best_selling_products/src/Service/ProductsService.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/best_selling_products/best_selling_products.module ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- Time: 96ms; Memory: 10MB

Comments & Activities

Issue created by @roshni27
Issue was unassigned.
Status changed to Needs review 12 months ago1:24pm 7 July 2023
Comment 12 months ago →
🇮🇳India roshni27
Please review the patch.
Status changed to RTBC 12 months ago12:12am 9 July 2023

Comment 12 months ago →

🇧🇪Belgium Frederikvho Belgium

Hi,

I applied the patch from comment #2 and ran PHPCS again and it didn't throw any warnings/errors.

(base) ➜  best_selling_products git:(8.x-3.x) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig .
(base) ➜  best_selling_products git:(8.x-3.x) ✗

Kind regards,
Frederik

Comment 9 months ago →
🇺🇦Ukraine artsays
Thank you guys for yours contribution
Due to module was updated found additional phpcs issues and attached as a patch
Status changed to Fixed 9 months ago2:03pm 7 October 2023
Comment 9 months ago →
🇺🇦Ukraine artsays
Status changed to Fixed 9 months ago2:05pm 7 October 2023
Comment 9 months ago →
🇺🇦Ukraine artsays
Status changed to Fixed 9 months ago2:17pm 7 October 2023
Comment 9 months ago →
🇺🇦Ukraine artsays
Latest and right version of the patch previously uploaded an empty file by mistake
Status changed to Fixed 9 months ago2:17pm 7 October 2023
Comment 9 months ago →
🇺🇦Ukraine artsays
Comment 9 months ago →
🇺🇦Ukraine artsays
Launched newest release 3.13 with fixed cs

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities