- Issue created by @anton4uk
- Status changed to Needs review
over 1 year ago 11:27am 7 July 2023 - last update
over 1 year ago 100 pass - Status changed to RTBC
about 1 year ago 6:24pm 9 November 2023 - Status changed to Needs work
about 1 year ago 1:52pm 20 December 2023 - π΅πΉPortugal jcnventura
This needs to be made a lot more robust.. Imagine you have a running site using this module just fine, and then decide to enable the key module.. Suddenly your keys no longer work, as the code in #2 suddenly expects that the configuration values refer to keys with the same name managed by the key module.
The way this should work is to refactor the client id and secret configuration to add a "provider" attribute that indicates the use of the key module. Naturally, the module should then be blocked if the key module is disabled.