Integrate with the key module

Created on 7 July 2023, almost 2 years ago

Problem/Motivation

Easy to use key module for "Client ID" and "Client Secret Key"

✨ Feature request
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine anton4uk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @anton4uk
  • Status changed to Needs review almost 2 years ago
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
    last update almost 2 years ago
    100 pass
  • Status changed to RTBC over 1 year ago
  • Status changed to Needs work over 1 year ago
  • πŸ‡΅πŸ‡ΉPortugal jcnventura

    This needs to be made a lot more robust.. Imagine you have a running site using this module just fine, and then decide to enable the key module.. Suddenly your keys no longer work, as the code in #2 suddenly expects that the configuration values refer to keys with the same name managed by the key module.

    The way this should work is to refactor the client id and secret configuration to add a "provider" attribute that indicates the use of the key module. Naturally, the module should then be blocked if the key module is disabled.

  • First commit to issue fork.
  • @svendecabooter opened merge request.
  • πŸ‡§πŸ‡ͺBelgium svendecabooter Gent

    I have created a merge request that reworks this concept, as suggested by jcnventura.
    It adds a "credentials_provider" to the plugin configuration, that defaults to "config", which will just keep on storing the client_id and client_secret in the plugin configuration, as is the case currently.
    If the "Key" module is installed, an optional second credentials provider gets added to the dropdown list, and users are able to optionally select a multivalue key for retrieving the appropriate credentials.

    If the Key module is not installed, nothing changes. If the key module is installed, nothing changes by default, but you can opt-in to use a Key rather than providing the credentials inline.

    Thanks for reviewing this MR and considering whether this could be added to the module.

  • πŸ‡§πŸ‡ͺBelgium svendecabooter Gent

    Patch version of the current MR state, for Composer based patching workflows.

Production build 0.71.5 2024