- Issue created by @andypost
- Status changed to Needs review
about 1 year ago 8:10pm 5 July 2023 - last update
about 1 year ago 29,797 pass - 🇫🇷France andypost
Looking how to add a test but looks it needs follow-up to remove Request object from class property (needs to be deprecated)
- last update
about 1 year ago 29,796 pass, 2 fail - 🇬🇧United Kingdom longwave UK
Duplicate of 🐛 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112 Needs work though I think this solution is better.
Also I wonder if this code is even used given 🐛 Truncated MailFrom address - Incorrect Windows detection Active
The last submitted patch, 3: 3372667-3.patch, failed testing. View results →
- last update
about 1 year ago Custom Commands Failed - 🇫🇷France andypost
Thank you! Better title
We can't use
DeprecatedServicePropertyTrait
as request is not a service and can't use__get()
because it makes deprecated property public, so not clear how to provide BC - Status changed to Postponed
about 1 year ago 9:29pm 5 July 2023 - 🇬🇧United Kingdom longwave UK
Let's move the fix to 🐛 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112 Needs work and then figure out how to deprecate the property once it's unused.