Deprecate PHPMail::request property

Deprecated function: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\Core\Mail\Plugin\Mail\PhpMail->mail() (line 114 of /var/www/html/web/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php) #0 /var/www/html/web/core/includes/bootstrap.inc(164): _drupal_error_handler_real() #1 [internal function]: _drupal_error_handler() #2 /var/www/html/web/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php(114): str_contains() #3 /var/www/html/web/core/lib/Drupal/Core/Mail/MailManager.php(307): Drupal\Core\Mail\Plugin\Mail\PhpMail->mail() #4 /var/www/html/web/core/lib/Drupal/Core/Mail/MailManager.php(180): Drupal\Core\Mail\MailManager->doMail() #5 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(583): Drupal\Core\Mail\MailManager->Drupal\Core\Mail\{closure}() #6 /var/www/html/web/core/lib/Drupal/Core/Mail/MailManager.php(179): Drupal\Core\Render\Renderer->executeInRenderContext() #7 /var/www/html/web/core/modules/update/update.fetch.inc(44): Drupal\Core\Mail\MailManager->mail() #8 /var/www/html/web/core/modules/update/update.module(193): _update_cron_notify() #9 /var/www/html/web/core/lib/Drupal/Core/Cron.php(335): update_cron() #10 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(388): Drupal\Core\Cron->Drupal\Core\{closure}() #11 /var/www/html/web/core/lib/Drupal/Core/Cron.php(318): Drupal\Core\Extension\ModuleHandler->invokeAllWith() #12 /var/www/html/web/core/lib/Drupal/Core/Cron.php(159): Drupal\Core\Cron->invokeCronHandlers() #13 /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Cron.php(75): Drupal\Core\Cron->run() #14 /var/www/html/web/core/modules/automated_cron/src/EventSubscriber/AutomatedCron.php(65): Drupal\Core\ProxyClass\Cron->run() #15 [internal function]: Drupal\automated_cron\EventSubscriber\AutomatedCron->onTerminate() #16 /var/www/html/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func() #17 /var/www/html/web/vendor/symfony/http-kernel/HttpKernel.php(100): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() #18 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(63): Symfony\Component\HttpKernel\HttpKernel->terminate() #19 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(688): Drupal\Core\StackMiddleware\StackedHttpKernel->terminate() #20 /var/www/html/web/vendor/drush/drush/src/Boot/DrupalBoot8.php(331): Drupal\Core\DrupalKernel->terminate() #21 [internal function]: Drush\Boot\DrupalBoot8->terminate() #22 {main}

Comments & Activities

Issue created by @andypost
Status changed to Needs review over 1 year ago8:10pm 5 July 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,797 pass
Comment over 1 year ago →
🇫🇷France andypost
Looking how to add a test but looks it needs follow-up to remove Request object from class property (needs to be deprecated)
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,796 pass, 2 fail
Comment over 1 year ago →
🇫🇷France andypost
Let's see if something will fail
Comment over 1 year ago →
🇫🇷France andypost
Fix component
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Duplicate of 🐛 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112 Needs work though I think this solution is better.

Also I wonder if this code is even used given 🐛 Truncated MailFrom address - Incorrect Windows detection Active
Comment over 1 year ago →
System Message
The last submitted patch, 3: 3372667-3.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Custom Commands Failed
Comment over 1 year ago →
🇫🇷France andypost
Thank you! Better title

We can't use DeprecatedServicePropertyTrait as request is not a service and can't use __get() because it makes deprecated property public, so not clear how to provide BC
Status changed to Postponed over 1 year ago9:29pm 5 July 2023
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Let's move the fix to 🐛 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112 Needs work and then figure out how to deprecate the property once it's unused.

Deprecate PHPMail::request property

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities