- Issue created by @mapac
- @mademo opened merge request.
- Status changed to Needs review
over 1 year ago 9:12am 6 July 2023 Buttons patterns are apply to Accordion-item, alert, carousel, modal, navbar and off-canvas.
- Assigned to Grimreaper
- Assigned to pdureau
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
What do you think about this MR?
I think there are relevant usages. For the case where there is a button but without btn and other classes, maybe not needed to call the pattern for that.
There are nice ideas to avoid code duplication too like in navbar, I think.
Maybe also looking at the details--accordion, fieldset and some commerce template, to be able to call matching patterns directly?
- Assigned to Grimreaper
-
Grimreaper →
committed 8520cb5a on 5.0.x
Issue #3372436 by Grimreaper: Use add_class filter instead of merge.
-
Grimreaper →
committed 8520cb5a on 5.0.x
-
Grimreaper →
committed c959787c on 5.0.x authored by
mademo →
Issue #3372436 by mademo, Grimreaper: Simplify some patterns by calling...
-
Grimreaper →
committed c959787c on 5.0.x authored by
mademo →
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 10:12am 19 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.