Support skip import rows if a field matches a certain value

@larowlan what do you think about this patch? I know in the current state we can do this by adding validation for this and then skip over the row but I thought having a plugin makes sense.

1. +++ b/src/Plugin/DatasetTransform/Skip.php
   @@ -0,0 +1,49 @@
   +      $skip = $this->configuration['not_equals'] ? ($field_value != $field_value_to_compare) : ($field_value == $field_value_to_compare);
   

   Can we have a strict comparison?

2. +++ b/tests/modules/data_pipelines_test/data_pipelines_test.data_pipelines.yml
   @@ -56,3 +56,26 @@ pipeline_with_no_validation:
   +      - plugin: skip
   

   Let's add a not-equal test as well.

3. +++ b/src/TransformValidDataIterator.php
   @@ -62,15 +62,15 @@ class TransformValidDataIterator extends \FilterIterator {
   +    if (count($dataset_data) === 0) {
   

   Would there be a case where we want to index and empty row? If yes then we have to update this logic. But I think we'd never want to index empty row.

+++ b/src/Plugin/DatasetTransform/Skip.php
@@ -0,0 +1,49 @@
+        return new DatasetData([]);

+++ b/src/TransformValidDataIterator.php
@@ -62,15 +62,15 @@ class TransformValidDataIterator extends \FilterIterator {
+    if (count($dataset_data) === 0) {

I think the idea is good, but I think throwing an Exception instead of overloading an empty dataset it more explicit.

🤔 Just when you thought we weren't getting even closer to migrate module

New patch included some feedback from comments.

Sorry previous patch has messy lint.

Can you please add the interdiff?

+++ b/src/TransformValidDataIterator.php
@@ -62,15 +63,18 @@ class TransformValidDataIterator extends \FilterIterator {
+      $this->dataset->addLogMessage(sprintf('Skip in row %d. %s', $this->position, $e->getMessage()), FALSE);

Let's make it more helpful.

Correct patch name with comment number.

Thank you for the changes.

+++ b/src/Plugin/DatasetTransform/Skip.php
@@ -0,0 +1,54 @@
+        $message = $this->configuration['not_equals'] ? sprintf('Value of "%s" is not equal to "%s"', $field_name, $field_value_to_compare)

Let's change this message to the following message.
> The value of the field "%s" is not equal to the value "%".

Thanks. I have updated the message.

+++ b/src/Exception/TransformSkipRecordException.php
@@ -0,0 +1,12 @@
+ * Class TransformSkipRecordException.

Can we get something useful on this one?

e.g. Provides an exception that is thrown when a row is skipped

Can be fixed on commit

Great work here folks 🎉

Thank you! Committed and pushed to 1.x. Fixed #15 on commit.

Automatically closed - issue fixed for 2 weeks with no activity.