Contrib.social

Remove pre-loading of fonts on RTL for the admin theme

Open on Drupal.org →
Created on 3 July 2023, about 1 year ago
Updated 10 September 2023, about 1 year ago

Problem/Motivation

Installing Varbase ~10.0.0 with a multilingual config
Or having the default language to not English

Steps to reproduce

Given that the default language of the Varbase ~10 was not English
When navigating to the back-end theme
Then the following errors shows up

Twig\Error\LoaderError: Template "@vartheme_claro/includes/preload.twig" is not defined in "themes/contrib/vartheme_claro/templates/html.html.twig" at line 50. in Twig\Loader\ChainLoader->getCacheKey() (line 99 of /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Loader/ChainLoader.php)
#0 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Environment.php(264): Twig\Loader\ChainLoader->getCacheKey()
#1 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Template/TwigEnvironment.php(204): Twig\Environment->getTemplateClass()
#2 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Template.php(319): Drupal\Core\Template\TwigEnvironment->getTemplateClass()
#3 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Environment.php(361) : eval()'d code(79): Twig\Template->loadTemplate()
#4 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Template.php(394): __TwigTemplate_e5c751fd132b7d52d4baf59980d09fe5->doDisplay()
#5 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling()
#6 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/Template.php(379): Twig\Template->display()
#7 /var/www/html/dev/varbase10x3/vendor/twig/twig/src/TemplateWrapper.php(40): Twig\Template->render()
#8 /var/www/html/dev/varbase10x3/docroot/core/themes/engines/twig/twig.engine(53): Twig\TemplateWrapper->render()
#9 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(372): twig_render_template()
#10 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Render/Renderer.php(436): Drupal\Core\Theme\ThemeManager->render()
#11 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender()
#12 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Render/Renderer.php(148): Drupal\Core\Render\Renderer->render()
#13 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Render/Renderer.php(583): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#14 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Render/Renderer.php(149): Drupal\Core\Render\Renderer->executeInRenderContext()
#15 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/Render/BareHtmlPageRenderer.php(66): Drupal\Core\Render\Renderer->renderRoot()
#16 /var/www/html/dev/varbase10x3/docroot/core/lib/Drupal/Core/ProxyClass/Render/BareHtmlPageRenderer.php(76): Drupal\Core\Render\BareHtmlPageRenderer->renderBarePage()
#17 /var/www/html/dev/varbase10x3/docroot/core/includes/install.core.inc(1056): Drupal\Core\ProxyClass\Render\BareHtmlPageRenderer->renderBarePage()
#18 /var/www/html/dev/varbase10x3/docroot/core/includes/install.core.inc(161): install_display_output()
#19 /var/www/html/dev/varbase10x3/docroot/core/install.php(48): install_drupal()
#20 {main}

Proposed resolution

Check more on the Add Preloaded Fonts in Vartheme

Following the new way in the new Drupal default front end theme 

{% include '@olivero/includes/preload.twig' with { olivero_path: olivero_path } only %}

Check the code on
The html.html.twig file ​
https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/themes/oliv...

The preload.twig file ​
https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/themes/oliv...

  • Remove pre-loading of fonts on RTL for the admin theme

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 10.0.0-beta1 → , vartheme_claro-4.0.0-beta1 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3371906 → : Removed pre-loading of fonts on RTL for the admin theme
🐛 Bug report
Status

Fixed

Version

4.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024