- Issue created by @dpineda
- Status changed to Needs review
over 1 year ago 10:30am 30 June 2023 - last update
over 1 year ago 103 pass - First commit to issue fork.
- Assigned to roshni27
- Status changed to Needs work
over 1 year ago 4:42pm 12 July 2023 - 🇮🇳India roshni27
I have applied above patch.
In Drupal, there is no direct method generateString() provided by the FileUrlGeneratorInterface. The correct method name to generate a file URL as a string representation would depend on the specific use case and context.This error related to drupal 10 compatibility.
I am working on it. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:06pm 12 July 2023 - last update
over 1 year ago 103 pass - last update
over 1 year ago Patch Failed to Apply - 🇪🇸Spain empesan
I've rerolled the patch because of several issues. Based on #2 and #6, here's a new patch with solves the following:
- #6 threw this error
Error: Object of class Drupal\Core\Url could not be converted to string in Drupal\flysystem\Asset\CssOptimizer->rewriteFileURI() (line 43 of /var/www/html/web/modules/contrib/flysystem/src/Asset/CssOptimizer.php
because $this->fileUrlGenerator->generate($path) returned a Core/Url object so I added the function to get the URI. - Fixed phpcs warnings/errors.
- Fixed phpstan warning errors including parent constructor.
- #6 threw this error
- last update
over 1 year ago 103 pass - 🇪🇸Spain empesan
#6 patch was wrong for 2.1.x branch due to I've already applied the previous patch. Attached rerolled patch with #7 fixes for 2.1.x-dev branch
- last update
over 1 year ago 103 pass - 🇧🇪Belgium dieterholvoet Brussels
The last patch caused an issue for me where base: prefixes were added to asset URLs, causing assets to not load. Calling
getUri
on theUrl
object is not enough because you can end up with internal URI's, you have to calltoString
in order to generate a publicly accessible URL. - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply -
lhridley →
committed 5aec5f81 on 2.1.x authored by
DieterHolvoet →
Issue #3371573 by roshni27, empesan, dpineda, DieterHolvoet, lhridley:...
-
lhridley →
committed 5aec5f81 on 2.1.x authored by
DieterHolvoet →
- Status changed to Fixed
over 1 year ago 6:21pm 30 July 2023 - 🇺🇸United States lhridley
Rerolled patch to apply to 2.1.x-dev branch after merging in other MRs, merge and marked as fixed. Thank you all!
- Status changed to Fixed
over 1 year ago 11:34pm 3 August 2023