We noticed that when adding two videos on the same line in the HTML, the filter would not replace them.
Add something like this to the HTML:
<p>{"preview_thumbnail":"/sites/default/files/styles/video_embed_wysiwyg_preview/public/video_thumbnails/B54L7ABWCrA.jpg?itok=7tr1jHG3","video_url":"https://youtu.be/B54L7ABWCrA","settings":{"responsive":true,"width":"854","height":"480","autoplay":false},"settings_summary":["Embedded Video (Adaptatif)."]}</p><p>{"preview_thumbnail":"/sites/default/files/styles/video_embed_wysiwyg_preview/public/video_thumbnails/MGJw7yOblDE.jpg?itok=S9CqaOKh","video_url":"https://youtu.be/MGJw7yOblDE","settings":{"responsive":true,"width":"854","height":"480","autoplay":false},"settings_summary":["Embedded Video (Adaptatif)."]}</p>
Because it is greedy, the regex in VideoEmbedWysiwyg::getValidMatches() captures this as one single group.
The regex should be ungreedy and should probably look for the first closing </p>.
Needs review
2.0
Code
Here is a patch for the above MR. It would be great if we could set ✨ Add support for Ckeditor 5 Needs review to RTBC, but that means that #3311063-34: Add support for Ckeditor 5 → (though not related to that ticket but to this one) should probably be fixed as well, as this patch here seems to do.