- Issue created by @pianomansam
- last update
over 1 year ago 9 pass - @pianomansam opened merge request.
- Status changed to Needs review
over 1 year ago 5:20pm 28 June 2023 - πΊπΈUnited States pianomansam
Created a patch to check that
$credentials
is an array before returning it. - Status changed to Needs work
over 1 year ago 12:35pm 5 July 2023 - πΊπΈUnited States fathershawn New York
Nice catch! I think it's more readable to do it like this:
return $credentials ?? [];
Since the key module call is enforcing arrays and the state call is either our array or null.
- last update
over 1 year ago 9 pass - Status changed to Needs review
over 1 year ago 2:21pm 5 July 2023 - πΊπΈUnited States fathershawn New York
Super! It also occurs to me that we should add a kernel test for this case that verifies the fix.
- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago 11 pass, 1 fail - last update
over 1 year ago 11 pass -
FatherShawn β
committed 3d94d1e1 on 4.0.x authored by
pianomansam β
Issue #3371112 by pianomansam, FatherShawn: Error: getCredentials():...
-
FatherShawn β
committed 3d94d1e1 on 4.0.x authored by
pianomansam β
- Status changed to Fixed
over 1 year ago 12:36pm 6 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.