- Issue created by @pedrop
- Status changed to Needs work
almost 2 years ago 2:41pm 28 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The feed passes validation.
Relative URLs are used for the article images. Those should be changed to absolute URLs to make the images visible even when users are watching to the articles from drupal.org. - 🇭🇺Hungary pedrop
Thanks for the quick feedback.
I checked and I can't find relative URLs in the feed.
All 6 img src attributes start with https://www.brainsum.com/sites/default/files/styles/.
Please let me know exactly where / how did you found relative urls. - Status changed to Needs review
almost 2 years ago 3:05pm 28 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Looking at the source of a page like https://www.brainsum.com/blog/connecting-drupal-hubspot-crm-v3-api, I see relative URLs used for images, for example in
<img loading="lazy" src="/sites/default/files/styles/blog_node_image/public/2023-06/Drupal%20and%20HubSpot%20-%202_0.jpg.webp?itok=joUPIaY3" width="1366" height="546" alt="HubSpot and Drupal logo" class="image-style-blog-node-image" />
or<img src="/sites/default/files/styles/blog_user_image_450/public/pictures/2020-05/pedro.jpg.webp?itok=Jzs1Z4iT" alt="" />
. The domain name is not included, differently from other URLs used for example in<noscript aria-hidden="true"><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-M8Q3QJF" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
or<a href="//linkedin.com/company/brainsum" target="_blank" rel="noopener"><i class="fab fa-linkedin"></i></a>
. - 🇮🇹Italy apaderno Brescia, 🇮🇹
That indeed is relevant only for articles that are shown completely on Planet Drupal. If an article is truncated before the images, the fact the images use relative URLs will not have any influence on how the article is rendered on drupal.org.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Never mind, the feed contains absolute URLs for the images.
- 🇭🇺Hungary pedrop
Thanks @apaderno,
Yes, the feed contains only the Leads of the articles and the Lead images with absolute URLs.
Is there anything else left before it can be approved? - Assigned to apaderno
- Status changed to Fixed
almost 2 years ago 7:36pm 30 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I added the feed to Planet Drupal ( https://www.drupal.org/aggregator/sources/2048 → ). Two articles have been added to Planet Drupal, since the others have been created more than three months and three weeks ago.
Automatically closed - issue fixed for 2 weeks with no activity.