- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:00pm 28 June 2023 - last update
over 1 year ago 11 pass - 🇺🇸United States fkelly
Thanks for proposing and testing this.
This same patch was included in patches for review in issue:
https://www.drupal.org/project/juicebox/issues/3371020 📌 Unused variable $bundle_entity_type. Closed: duplicate
This whole "batch of patches" is waiting review. Maybe I'll follow your lead and run them all through the CI test process to expedite things. This one patch seems relatively straightforward. Some of the other patches in the batch (3371020) get into code in the test directory that Leber got working after it had languished for 2+ years and I wanted to give him time to look them over.
- Status changed to Closed: duplicate
over 1 year ago 2:08am 9 August 2023 - 🇺🇸United States luke.leber Pennsylvania
This has been included in https://www.drupal.org/project/juicebox/issues/3351683 📌 [PP-1] Resolve all coding standard violations Postponed . I'm closing this task out, but am also moving issue credits to be included in #3351683.
Having many issues to resolve simple coding standards violations isn't ideal and could reflect badly in credit system gaming ways, so I'm opting to resolve them all in one fell swoop instead.