Update CKEditor 5 to 38.1.0

Given that this fixes a critical data loss bug ( 🐛 [upstream] [GHS] CKEditor 5 removes s that wrap HTML elements not natively supported by CKEditor 5 Fixed ), bumping to .

Since this passes tests, RTBC'ing.

MINOR BREAKING CHANGES ℹ️
html-support: The htmlAttributes model property has been replaced by html*Attributes, where the * represents the name of the view element. Clients will need to modify their code accordingly by replacing all instances of htmlAttributes with html*Attributes for the respective view elements.

It looks like core is not impacted by this even though we are using htmlAttributes for Drupal Media. It does look like this will break at least UI Styles contrib module but it's used by 414 sites. Ideal way to address this would be to remove their usage of htmlAttributes and use the CKEditor 5 core APIs instead.

Can we open an issue against UI Styles (not necessarily with a patch but at least a heads up)?

Spoke to @lauriii in irc, UI Styles is still in the progress of updating for 10.1, so we wouldn't be breaking existing sites that use it. Given this fixes critical data loss bugs, I think we should just go ahead and commit it to 10.1.x - but asap so it gets into 10.1.1 and the minimal number of sites go from 10.1.0 to 10.1.1 vs 10.0.x to 10.1.1

I did some manual testing to confirm that the issues mentioned in #3 are indeed solved. It looks like there's really good progress there! I wasn't able to convert an existing element to a <div> which is needed to be able to close 🐛 [Style] Add tests for inability to apply styles to , , , etc. in CKEditor 5 — and allows applying it to all elements Fixed . Applying styles to <ul> and <table> worked just as I would have expected. 🤩 Confirmed also that wrapping <a> for elements not supported by CKEditor 5 are retained.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

#7++ — that's exactly the rationale I mentioned to @lauriii too :)

#8:

I wasn't able to convert an existing element to a

which is needed to be able to close […]

Yes, I called that out in detail over at #3326261-51: [upstream] [Style] Unable to apply styles to

,

,
,

Automatically closed - issue fixed for 2 weeks with no activity.