- Issue created by @lauriii
- Status changed to Needs review
almost 2 years ago 12:02pm 28 June 2023 - last update
almost 2 years ago 29,562 pass - đ§đĒBelgium wim leers Ghent đ§đĒđĒđē
Thank you, you beat me to it! đ
If all is well, then this release with NO major breaking changes (which they explicitly did at our request to address as many of
- the most-upgrade-blocking problems in đą [meta] [upstream] Prioritized CKEditor 5 upstream blockers Active during 10.1 rather than waiting for Drupal 10.2 in December! đđ) fixes:
- the widely reported
Style-support-for-<div>problem: applying a class to a div now works using the UI! #3326261-51: [upstream] [Style] Unable to apply styles to,- ,
- the often reported "bleeding" of styles:
#3326261-51: [upstream] [Style] Unable to apply styles to ,
- ,
- ,
- đ [upstream] [GHS] CKEditor 5 removes s that wrap HTML elements not natively supported by CKEditor 5 Fixed
- Status changed to RTBC
almost 2 years ago 1:15pm 28 June 2023 - đ§đĒBelgium wim leers Ghent đ§đĒđĒđē
Given that this fixes a critical data loss bug ( đ [upstream] [GHS] CKEditor 5 removes s that wrap HTML elements not natively supported by CKEditor 5 Fixed ), bumping to .
Since this passes tests, RTBC'ing.
- đĢđŽFinland lauriii Finland
MINOR BREAKING CHANGES âšī¸
html-support: The htmlAttributes model property has been replaced by html*Attributes, where the * represents the name of the view element. Clients will need to modify their code accordingly by replacing all instances of htmlAttributes with html*Attributes for the respective view elements.It looks like core is not impacted by this even though we are using
htmlAttributesfor Drupal Media. It does look like this will break at least UI Styles contrib module but it's used by 414 sites. Ideal way to address this would be to remove their usage ofhtmlAttributesand use the CKEditor 5 core APIs instead. - đŦđ§United Kingdom catch
Can we open an issue against UI Styles (not necessarily with a patch but at least a heads up)?
- đŦđ§United Kingdom catch
Spoke to @lauriii in irc, UI Styles is still in the progress of updating for 10.1, so we wouldn't be breaking existing sites that use it. Given this fixes critical data loss bugs, I think we should just go ahead and commit it to 10.1.x - but asap so it gets into 10.1.1 and the minimal number of sites go from 10.1.0 to 10.1.1 vs 10.0.x to 10.1.1
- đĢđŽFinland lauriii Finland
I did some manual testing to confirm that the issues mentioned in #3 are indeed solved. It looks like there's really good progress there! I wasn't able to convert an existing element to a
<div>which is needed to be able to close đ [Style] Add tests for inability to apply styles to , , , etc. in CKEditor 5 â and allows applying it to all elements Fixed . Applying styles to<ul>and<table>worked just as I would have expected. 𤊠Confirmed also that wrapping<a>for elements not supported by CKEditor 5 are retained. - Status changed to Fixed
almost 2 years ago 9:04am 29 June 2023 - đŦđ§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
- đ§đĒBelgium wim leers Ghent đ§đĒđĒđē
#7++ â that's exactly the rationale I mentioned to @lauriii too :)
#8:
I wasn't able to convert an existing element to a
which is needed to be able to close [âĻ]Yes, I called that out in detail over at #3326261-51: [upstream] [Style] Unable to apply styles to
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 1:00pm 28 July 2023
- , etc. in CKEditor 5 â and allows applying it to all elements â
etc. in CKEditor 5 â and allows applying it to all elements âThat's 3 issues that are often blocking the switch from CKEditor 4 to 5 solved, one of which is a data loss bug.
Ideally, this release would ship in Drupal
10.1.1!
etc. in CKEditor 5 â and allows applying it to all elements â. But the critical data loss part is solved đProduction build 0.71.5 2024 - the often reported "bleeding" of styles:
#3326261-51: [upstream] [Style] Unable to apply styles to
