- Issue created by @marchuk.vitaliy
- Assigned to arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:17am 28 June 2023 - Assigned to Akshay kashyap
- Issue was unassigned.
- 🇮🇳India Akshay kashyap
@arti_parmar
Thanks for the work
I have reviewed and tested the #3 patch. It has been successfully applied and looks good. Patch #3 fixes all Drupal coding standards mentioned in PHPCS.
git apply -v 3370881-3.patch Checking patch README.md... Checking patch commerce_moneris_checkout.module... Checking patch src/Event/MonerisCheckoutEvents.php... Checking patch src/Event/MonerisCheckoutTransactionCompleteEvent.php... Checking patch src/MonerisCheckoutResponseCodes.php... Checking patch src/MonerisCheckoutResponseStates.php... Checking patch src/Plugin/Commerce/PaymentGateway/MonerisCheckout.php... Checking patch src/PluginForm/MonerisCheckoutForm.php... Applied patch README.md cleanly. Applied patch commerce_moneris_checkout.module cleanly. Applied patch src/Event/MonerisCheckoutEvents.php cleanly. Applied patch src/Event/MonerisCheckoutTransactionCompleteEvent.php cleanly. Applied patch src/MonerisCheckoutResponseCodes.php cleanly. Applied patch src/MonerisCheckoutResponseStates.php cleanly. Applied patch src/Plugin/Commerce/PaymentGateway/MonerisCheckout.php cleanly. Applied patch src/PluginForm/MonerisCheckoutForm.php cleanly.Moving to RTBC
- Status changed to RTBC
over 1 year ago 10:47am 28 June 2023 - @marchukvitaliy opened merge request.
- 🇺🇦Ukraine marchuk.vitaliy Rivne, UA
Opened MR with the fixes. Also added many fixes related to the payment gateway and general code structure.
-
marchuk.vitaliy →
committed 3c3c41a9 on 1.x
Issue #3370881: Fix Drupal coding standards
-
marchuk.vitaliy →
committed 3c3c41a9 on 1.x
- Status changed to Fixed
over 1 year ago 7:19am 29 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.