phpcs: coding standards

PHP CODE SNIFFER VIOLATION SOURCE SUMMARY ----------------------------------------------------------------------------- SOURCE COUNT ----------------------------------------------------------------------------- [ ] DrupalPractice.Objects.GlobalFunction.GlobalFunction 37 [x] Drupal.Commenting.InlineVariableComment.VarInline 12 [x] Drupal.Commenting.TodoComment.TodoFormat 11 [ ] DrupalPractice.Objects.GlobalDrupal.GlobalDrupal 6 [ ] Drupal.Commenting.GenderNeutralComment.GenderNeutral 4 [ ] Drupal.Commenting.ClassComment.Short 3 [ ] DrupalPractice.Constants.GlobalConstant.GlobalConstant 2 [ ] Drupal.Arrays.Array.LongLineDeclaration 1 [ ] Drupal.Commenting.FunctionComment.MissingParamComment 1 [ ] DrupalPractice.Variables.GetRequestData.SuperglobalAccessedWithVar 1 ----------------------------------------------------------------------------- A TOTAL OF 78 SNIFF VIOLATIONS WERE FOUND IN 10 SOURCES ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SOURCES AUTOMATICALLY (23 VIOLATIONS IN TOTAL) -----------------------------------------------------------------------------

Comments & Activities

Issue created by @bluegeek9
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
6 pass
@bluegeek9 opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
6 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
6 pass
Comment over 1 year ago →
System Message

bluegeek9 → committed 5e256de1 on 8.x-1.x
Issue #3370781 by bluegeek9: phpcs: coding standards
Comment over 1 year ago →
System Message

bluegeek9 → authored 67cbcc20 on 8.x-1.x
Issue #3370781 by bluegeek9: phpcs: coding standards
Comment over 1 year ago →
System Message

bluegeek9 → authored c81664bb on 8.x-1.x
Issue #3370781 by bluegeek9: phpcs: coding standards
Issue was unassigned.
Status changed to Fixed about 1 year ago9:33pm 2 October 2023
Comment about 1 year ago →
🇺🇸United States bluegeek9
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed 12 months ago8:00pm 21 November 2023
Comment 12 months ago →
🇨🇦Canada dtarc
Hi,

We ran into an error on updating from 8.x-1.0 to 8.x-1.1 because the constructor for MessageController changed.

It went from:

public function __construct() {

to:

public function __construct(EntityAccessControlHandlerInterface $access_handler, FormBuilderInterface $form_builder) {

Is there any reason for this API breaking change in a minor point release? Thanks.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities