- Issue created by @evonasek
- 🇵🇱Poland michal.k Wrocław
Hi,
Please check if you can apply my patch. It fixes library definition according to documentation and it fixes this issue in multilingual websites:
https://www.drupal.org/docs/develop/creating-modules/adding-assets-css-j... →This 3370546-01_fix_to_remove_https.patch patch does not resolve the issue on websites that are presented via http protocol.
Another thing to consider is to remove the library from this module and add a required dependency of openeuropa/oe_webtools. Since this library is already there defined correctly and included:
https://github.com/openeuropa/oe_webtools/blob/master/oe_webtools.librar...Kind regards,
Michał Kozłowski. - Status changed to Needs review
over 1 year ago 8:17am 3 July 2023 - First commit to issue fork.
- @dieterholvoet opened merge request.
- 🇧🇪Belgium dieterholvoet Brussels
I applied a combination of the patches of evonasek and michal.k. Thanks for your contributions!
Another thing to consider is to remove the library from this module and add a required dependency of openeuropa/oe_webtools
I'm hesitant to do that because that module is not hosted on Drupal.org, which means I can only add the dependency to
composer.json
and not toinfo.yml
. Maybe I will change this in a follow-up issue. -
DieterHolvoet →
committed edc5cc51 on 1.x
Issue #3370546 by evonasek, DieterHolvoet, michal.k: Error is thrown if...
-
DieterHolvoet →
committed edc5cc51 on 1.x
- Status changed to Fixed
over 1 year ago 11:15am 4 July 2023 - 🇧🇪Belgium dieterholvoet Brussels
About the Drupal 10 compatibility: just fixed that one in 📌 Automated Drupal 10 compatibility fixes Fixed .
Automatically closed - issue fixed for 2 weeks with no activity.