- Issue created by @Project Update Bot
This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
- Merge request !5Issue #3369369: Automated Drupal 10 compatibility fixes → (Closed) created by suresh7787
- First commit to issue fork.
- 🇳🇱Netherlands watergate
Watergate → changed the visibility of the branch 3369369-automated-drupal-10-1 to hidden.
- 🇳🇱Netherlands watergate
Watergate → changed the visibility of the branch 3369369-automated-drupal-10-1 to active.
- 🇳🇱Netherlands watergate
Watergate → changed the visibility of the branch 3369369-automated-drupal-10 to hidden.
- Merge request !7Applied the patch provided by the Project Update Bot. → (Merged) created by watergate
- 🇳🇱Netherlands watergate
I looked into this issue to get this module working with Drupal 10. While updating/applying the patch provided by the Project Update Bot in the issue fork, I noticed that in 📌 Remove deprecated MediaRevisionAccessCheck in Drupal 10 Fixed , the
core_version_requirement
already had been updated, but this is not included in a release yet. - 🇦🇺Australia mingsong 🇦🇺
Thanks @Niels for looking into it.
Yes, that is right. That patch has been merged into the develop branch.
As I explained in #11 📌 Remove deprecated MediaRevisionAccessCheck in Drupal 10 Fixed The reason why no release for it is that the change involved access checking, in other words, it requires a security review closely. Develop version means not ready for production yet, but for testing.
- 🇳🇱Netherlands watergate
@Mingsong, thanks for your reply. I understand your point that "dev"-versions shouldn't be used in production. But the functionality of 📌 Remove deprecated MediaRevisionAccessCheck in Drupal 10 Fixed , which has been merged already, is blocking a Drupal 10-compatible release for this module.
I propose rolling back the functionality that needs explicit testing, using that to create a Drupal 9 and 10 compatible release, and tagging it as 1.1.0. In combination, make a 2.0.0-alpha1 version compatible with Drupal 10 (and 9?), which contains the functionality that needs explicit testing. We can then use the project page and release notes to point users for feedback on the changed functionality (that is included as an alpha release).
Please let me know if you agree with the above proposition and need help.
For others who want to install this module in Drupal 10, I've attached a small patch to this issue, which can be used with the mglaman/composer-drupal-lenient and orakili/composer-drupal-info-file-patch-helper Composer plugins to ease Drupal10 upgrade.
- 🇦🇺Australia mingsong 🇦🇺
This module has been looking for a maintainer to take over, who will be in charge of D10 versions and beyond.
- 🇳🇱Netherlands watergate
@Mingsong, you can add me as a maintainer. I will create the Drupal 10 compatible release and help where needed.
- 🇦🇺Australia mingsong 🇦🇺
@Niels, thanks for offering the help.
I just sent you an email to discuss your kind help.
Looking forward to hearing from you.
- 🇳🇱Netherlands watergate
I have updated the merge-request, by reverting the commit that changed the access checking. So that we can create a Drupal 10 compatible release using the 1.0.x branch, and continue the work for new functionality on the 2.x branch.
-
Watergate →
committed 9f365d2d on 1.0.x
Issue #3369369 by Watergate, Project Update Bot, Mingsong: Automated...
-
Watergate →
committed 9f365d2d on 1.0.x
- Status changed to Fixed
12 months ago 4:16pm 6 December 2023 - Assigned to watergate
- Status changed to Active
12 months ago 7:12pm 6 December 2023 - 🇳🇱Netherlands watergate
Sorry, I now understand that the Media diff UI plugin sub-module uses deprecated functionality in Drupal 10. I will, therefore, change the
core_version_requirement
for that specific sub-module. In case the Media diff UI plugin sub-module is needed in a Drupal 10 installation, the 2.0.0-alpha1 version of this module can be used, but the introduced access changes should be reviewed closely (as indicated in #3369369-11: Automated Drupal 10 compatibility fixes → ). - 🇳🇱Netherlands watergate
Watergate → changed the visibility of the branch 1.0.x to hidden.
- 🇳🇱Netherlands watergate
Watergate → changed the visibility of the branch 2.x to hidden.
- Issue was unassigned.
- Status changed to Fixed
12 months ago 8:08pm 6 December 2023 - 🇳🇱Netherlands watergate
I will add the change in 📌 Downgrade core_version_requirement for Media diff UI plugin sub-module Active .
Automatically closed - issue fixed for 2 weeks with no activity.