Promote symfony/finder from dev-dependency to full dependency

Is there any other core code we'd be able to replace with this?

There are certainly other instances in core that could be replaced by finder. The following are a few places that seem like potential benefactors:

• Drupal\Core\Config\InstallStorage
• Drupal\Core\Asset\LibrariesDirectoryFileFinder
• drupal_find_theme_templates()

Another potential spot is adding it to the core filesystem service to expand the capabilities of that service

#1451320: Evaluate Symfony2's Finder Component to simplify file handling → already discussed this a bit.

Updated issue summary

Core already using custom iterators so not sure this component makes sense to use - there's only 3 places to apply it according #4

Would be great to provide examples hot this component will improve DX

PS: drush already depends on it

This is blocking 📌 Making a theme compatible with core's theme generator is too difficult Needs work , so matching issue metadata.

@andy-blum Why a new issue? The existing issues have many more followers, and are likely to proceed faster. 😅

Personally, as a module and distribution profile maintainer who maintains a lot of scaffolding tools, I've had to add symfony/finder and symfony/filesystem as not-dev dependencies myself to the projects I work on. In fact, I found it odd that Drupal Core didn't provide these as dependencies already.

I would support adding the dependency for all, and then separately follow-up for D11 to see how we could reduce and switch more things over to the Symfony version. But I don't think the latter should be a hard blocker to solving this for the starterkit generator, which we desperately need as an install profile with a "starterkit" base theme.

We do not want drupal/core-dev as a dependency for anything, we have encountered issues bringing that into consumer sites because of the composer/composer dependency.

Opened ✨ Add Symfony's Filesystem and Finder components to core Active for the work following this dependency evaluation.

We discussed this in Lille and @catch and @longwave agreed to add the components as regular dependencies.

Automatically closed - issue fixed for 2 weeks with no activity.