Contrib.social

Jquery once library obsolete in Drupal 10

Open on Drupal.org →
Created on 23 June 2023, about 1 year ago
Updated 3 August 2023, 11 months ago

Problem/Motivation

I upgrade the module to v 2.0.0 because we are preparing our project to upgrade Drupal 10.

Then we check the compatibility of the module with Upgrade Status module, and this show an problem:

The js library "date_all_day" has a dependency with "jquery.once" but the script "date_all_day.js" is not using that JQuery library.

Proposed resolution

Remove the dependency of "query.once" library from "date_all_days.libraries.yml".

🐛 Bug report
Status

RTBC

Version

2.0

Component

Code

Created by

🇪🇸Spain lpeidro Madrid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @lpeidro
  • @lpeidro opened merge request.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇪🇸Spain lpeidro Madrid

    I open a MR.

    The fix is not completed because the script "date_all_day.js" does not use "jquery.once".

  • Comment about 1 year ago →
    🇪🇸Spain akalam

    I will try to provide a fix this evening by refactoring the javascript so we get rid of jquery completely and we replace jquery.once by core/once

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇪🇸Spain akalam
  • First commit to issue fork.
  • Issue was unassigned.
  • Status changed to RTBC 11 months ago
  • Comment 11 months ago →
    🇭🇺Hungary szato

    Regarding to D10 readiness, the MR in #2 is correct.

    It would be great to merge it, to not block D10 readiness and open a new issue for js code refactoring if it needed.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024